Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to support methods with worker attributes. #116

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

Chaithra-07
Copy link
Contributor

This changes includes:

  1. InputParam and OutputParam attribute
  2. Worker execute method implementation
  3. Testcases to verify the attribute changes.

closes #107


namespace Tests.Worker
{
[WorkerTask]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to annotate the class itself?

Copy link
Contributor Author

@Chaithra-07 Chaithra-07 Apr 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, a condition in the existing method DiscoverWorkers checks if the types (classes, interfaces, structs, etc.) are marked with a custom attribute WorkerTask.

@Jithesh-poojary Jithesh-poojary requested a review from v1r3n April 24, 2024 08:35
@v1r3n v1r3n merged commit 71c5017 into conductor-sdk:main Apr 30, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support methods with worker attributes similar to Java/Python
2 participants